Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test eeac91e |
Contributor
📝 WalkthroughWalkthroughAdds a RUN command to the Dockerfile that installs the Megatron-LM package from the 3rdparty directory in editable mode without dependencies during the Docker image build process. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker/Dockerfile.ci`:
- Around line 58-59: The RUN line in the Dockerfile is passing arguments in the
wrong order so -e treats --no-deps as its path; update the pip install
invocation in the RUN that targets /opt/Megatron-Bridge/3rdparty/Megatron-LM so
that --no-deps appears before the editable flag (e.g., use "--no-deps -e .") or
otherwise ensure -e's argument is the project path, keeping the same directory
and installation intent.
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/build/compile-helper
branch
from
7228528 to
28d7381
Compare
chtruong814
approved these changes
Feb 17, 2026
thomasdhc
approved these changes
Feb 17, 2026
This was referenced Feb 18, 2026
pengdurice
pushed a commit
to pengdurice/Megatron-Bridge
that referenced
this pull request
Feb 24, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: pengdurice <pengduhit@gmail.com>
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Without this PR, the compiled file
helpers_cpp.cpython-312-x86_64-linux-gnu.sois missingChangelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit
Release Notes